Bug 200947 - Web Inspector: Page: re-add enable/disable after r248454
Summary: Web Inspector: Page: re-add enable/disable after r248454
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 200854
  Show dependency tree / graph
 
Reported: 2019-08-20 15:43 PDT by Devin Rousso
Modified: 2019-08-26 17:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (32.09 KB, patch)
2019-08-20 16:18 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (27.53 KB, patch)
2019-08-21 03:30 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-20 15:43:55 PDT 
.
Comment 1 Devin Rousso 2019-08-20 16:18:56 PDT 
Created attachment 376825 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-20 23:55:49 PDT 
Comment on attachment 376825 [details]
Patch

r=me
Comment 3 Devin Rousso 2019-08-21 03:30:55 PDT 
Created attachment 376860 [details]
Patch

There are some timing issues for CSS commands being sent before Page.enable, as CSS (via DOM) doesn't wait for a target to exist
Comment 4 WebKit Commit Bot 2019-08-21 09:50:20 PDT 
Comment on attachment 376860 [details]
Patch

Clearing flags on attachment: 376860

Committed r248943: <https://trac.webkit.org/changeset/248943>
Comment 5 WebKit Commit Bot 2019-08-21 09:50:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-21 09:51:18 PDT 
<rdar://problem/54559513>