In various build-steps in EWS, there is a custom failure message (e.g.: 2 style errors), however an additional (failure) is appended at the end (making it: 2 style errors (failure)). The additional (failure) string in unnecessary and makes the text less readable. We should remove this additional string. Other example: 3 api tests failed or timed out (failure)
Created attachment 377248 [details] Patch
Attachment 377248 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:507: [TestWithFailureCount.getResultSummary] Instance of 'TestWithFailureCount' has no 'results' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:261: [TestCheckStyle.test_failures_with_style_issues] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:261: [TestCheckStyle.test_failures_with_style_issues] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1832: [TestRunAPITests.test_one_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1832: [TestRunAPITests.test_one_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1888: [TestRunAPITests.test_multiple_failures_and_timeouts] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1888: [TestRunAPITests.test_multiple_failures_and_timeouts] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sample run: Without this patch: https://ews-build.webkit-uat.org/#/builders/5/builds/4968 With this patch: https://ews-build.webkit-uat.org/#/builders/5/builds/4969
Comment on attachment 377248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377248&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:509 > + return {u'step': unicode(status)} What prompted this change? Do we have an example of status being something other than ASCII?
Comment on attachment 377248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377248&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:509 >> + return {u'step': unicode(status)} > > What prompted this change? Do we have an example of status being something other than ASCII? The above code refactoring prompted this. Earlier the 'status' variable was always unicode. After this change, in case of self.failedTestCount, 'status' is not unicode, so we need to convert it to unicode. Buildbot expects the returned status to be unicode (and throws an exception if it's not a unicode).
Comment on attachment 377248 [details] Patch Clearing flags on attachment: 377248 Committed r249104: <https://trac.webkit.org/changeset/249104>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54713089>