Bug 201813 - [WebAuthn] REGRESSION (r249059): Leak of WKMockNFTag objects and WKMockNFTag instance variables
Summary: [WebAuthn] REGRESSION (r249059): Leak of WKMockNFTag objects and WKMockNFTag ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-15 22:14 PDT by David Kilzer (:ddkilzer)
Modified: 2019-09-16 15:05 PDT (History)
7 users (show)

See Also:


Attachments
Patch v1 (2.77 KB, patch)
2019-09-15 22:19 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-09-15 22:14:13 PDT
Leak of WKMockNFTag instances (missing -release) and WKMockNFTag instance variables (missing -dealloc).

Regressed with:

Bug 188624: [WebAuthn] Support NFC authenticators for iOS
<https://bugs.webkit.org/show_bug.cgi?id=188624>
<https://trac.webkit.org/changeset/249059/webkit>
Comment 1 Radar WebKit Bug Importer 2019-09-15 22:14:24 PDT
<rdar://problem/55387597>
Comment 2 David Kilzer (:ddkilzer) 2019-09-15 22:19:06 PDT
Created attachment 378839 [details]
Patch v1
Comment 3 WebKit Commit Bot 2019-09-16 11:29:56 PDT
Comment on attachment 378839 [details]
Patch v1

Clearing flags on attachment: 378839

Committed r249907: <https://trac.webkit.org/changeset/249907>
Comment 4 WebKit Commit Bot 2019-09-16 11:29:57 PDT
All reviewed patches have been landed.  Closing bug.