Bug 201818 - check-webkit-style: Fix warning message for std::make_unique<typename[]>
Summary: check-webkit-style: Fix warning message for std::make_unique<typename[]>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-16 06:19 PDT by David Kilzer (:ddkilzer)
Modified: 2019-09-16 10:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (4.48 KB, patch)
2019-09-16 06:36 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-09-16 06:19:05 PDT 
Fix warning message for std::make_unique<_typename_[]> in check-webkit-style.

When writing the patch for Bug 201804, it was not clear from check-webkit-style output that I hand to switch from std::make_unique<uint32_t[]>(size) to WTF::makeUniqueArray<uint32_t>(size).
Comment 1 Radar WebKit Bug Importer 2019-09-16 06:19:22 PDT 
<rdar://problem/55397921>
Comment 2 David Kilzer (:ddkilzer) 2019-09-16 06:36:10 PDT 
Created attachment 378857 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2019-09-16 09:32:31 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Created attachment 378857 [details]
> Patch v1

This patch can't possibly affect ios-wk2 tests.  Looks like that failure was caused by a flaky test.
Comment 4 WebKit Commit Bot 2019-09-16 10:44:55 PDT 
Comment on attachment 378857 [details]
Patch v1

Clearing flags on attachment: 378857

Committed r249906: <https://trac.webkit.org/changeset/249906>
Comment 5 WebKit Commit Bot 2019-09-16 10:44:56 PDT 
All reviewed patches have been landed.  Closing bug.