Bug 201873 - run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
Summary: run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-17 09:45 PDT by David Kilzer (:ddkilzer)
Modified: 2019-09-17 10:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch v1 (1.58 KB, patch)
2019-09-17 09:47 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-09-17 09:45:25 PDT 
Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test() in run-webkit-tests.

This breaks traditional leaks checking (added in Bug 193772) and document leak checking at the end of each testing shard.  (This regressed sometime after the fix for Bug 193772 was landed.  I think it was related to fixing test timeouts on bots.)
Comment 1 Radar WebKit Bug Importer 2019-09-17 09:45:54 PDT 
<rdar://problem/55442387>
Comment 2 David Kilzer (:ddkilzer) 2019-09-17 09:47:50 PDT 
Created attachment 378971 [details]
Patch v1
Comment 3 WebKit Commit Bot 2019-09-17 10:50:33 PDT 
Comment on attachment 378971 [details]
Patch v1

Clearing flags on attachment: 378971

Committed r249965: <https://trac.webkit.org/changeset/249965>
Comment 4 WebKit Commit Bot 2019-09-17 10:50:35 PDT 
All reviewed patches have been landed.  Closing bug.