Bug 205223 - Add release assert for selectedIndex in WebKit::WebPopupMenu::show()
Summary: Add release assert for selectedIndex in WebKit::WebPopupMenu::show()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-13 16:05 PST by David Kilzer (:ddkilzer)
Modified: 2019-12-14 05:03 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (11.54 KB, patch)
2019-12-13 17:02 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-12-13 16:05:13 PST 
Add release assert for selectedIndex in WebKit::WebPopupMenu::show().

The WebCore::RenderMenuList::showPopup() derives selectedIndex from the render tree, while WebKit::WebPopupMenu::show() calls WebKit::WebPopupMenu::populateItems() which uses the DOM via WebCore::HTMLSelectElement::listItems() which may call WebCore::HTMLSelectElement::recalcListItems().
Comment 1 Radar WebKit Bug Importer 2019-12-13 16:05:38 PST 
<rdar://problem/57929078>
Comment 2 David Kilzer (:ddkilzer) 2019-12-13 17:02:38 PST 
Created attachment 385662 [details]
Patch v1
Comment 3 WebKit Commit Bot 2019-12-14 05:03:14 PST 
Comment on attachment 385662 [details]
Patch v1

Clearing flags on attachment: 385662

Committed r253523: <https://trac.webkit.org/changeset/253523>
Comment 4 WebKit Commit Bot 2019-12-14 05:03:15 PST 
All reviewed patches have been landed.  Closing bug.