Bug 206448 - [JSC] Add missing header guards
Summary: [JSC] Add missing header guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 15:18 PST by David Kilzer (:ddkilzer)
Modified: 2020-01-18 23:06 PST (History)
11 users (show)

See Also:

Attachments
Patch v1 (2.17 KB, patch)
2020-01-17 15:21 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-01-17 15:18:21 PST 
Add missing header guards to JavaScriptCore headers as found by lgtm.com:

    Source/JavaScriptCore/heap/IsoHeapCellType.h
    Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h
Comment 1 David Kilzer (:ddkilzer) 2020-01-17 15:21:12 PST 
Created attachment 388095 [details]
Patch v1
Comment 2 Keith Miller 2020-01-17 18:20:46 PST 
Lol, we should really have a style warning for this...
Comment 3 WebKit Commit Bot 2020-01-17 18:49:39 PST 
Comment on attachment 388095 [details]
Patch v1

Clearing flags on attachment: 388095

Committed r254787: <https://trac.webkit.org/changeset/254787>
Comment 4 WebKit Commit Bot 2020-01-17 18:49:40 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-17 18:50:18 PST 
<rdar://problem/58703846>
Comment 6 David Kilzer (:ddkilzer) 2020-01-18 22:39:44 PST 
(In reply to Keith Miller from comment #2)
> Lol, we should really have a style warning for this...

We do have a check, but it wasn't very good because it assumed any header that didn't already have #ifndef/#define/#endif or #pragma once was an Objective-C header that didn't need a header guard.

Improving this in Bug 206480.