Bug 208938 - commit-queue should skip testing if patch already passed tests on mac-wk2 queue
Summary: commit-queue should skip testing if patch already passed tests on mac-wk2 queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on: 208940 209342
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-11 12:48 PDT by Aakash Jain
Modified: 2020-03-21 02:51 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.20 KB, patch)
2020-03-20 13:00 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (10.20 KB, patch)
2020-03-20 14:02 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch for landing (11.06 KB, patch)
2020-03-20 14:13 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-11 12:48:34 PDT
commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue. 

Both commit-queue and mac-wk2 queue run same tests (WK2 layout-tests in release mode).
Comment 1 Alexey Proskuryakov 2020-03-11 12:56:45 PDT
IIRC the old queue would re-test if substantial amount of time passed since the EWS run.

We had a lot of discussion about stricter logic in the past (e.g. don't land until all EWSes were done), but no concrete changes planned.
Comment 2 Aakash Jain 2020-03-20 13:00:00 PDT
Created attachment 394113 [details]
Patch
Comment 3 Aakash Jain 2020-03-20 13:00:19 PDT
Comment on attachment 394113 [details]
Patch

Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/1660
Comment 4 Aakash Jain 2020-03-20 13:22:25 PDT
(In reply to Alexey Proskuryakov from comment #1)
> IIRC the old queue would re-test if substantial amount of time passed since the EWS run.
I don't see any logic regarding time limit for re-testing in old EWS code https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L434 (and the code hasn't changed in a long time)
Comment 5 Aakash Jain 2020-03-20 14:02:09 PDT
Created attachment 394122 [details]
Patch
Comment 6 Aakash Jain 2020-03-20 14:13:18 PDT
Created attachment 394125 [details]
Patch for landing
Comment 7 EWS 2020-03-20 14:38:42 PDT
Committed r258790: <https://trac.webkit.org/changeset/258790>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394125 [details].
Comment 8 Radar WebKit Bug Importer 2020-03-20 14:39:13 PDT
<rdar://problem/60705157>
Comment 9 Aakash Jain 2020-03-21 02:51:09 PDT
Updated bug title to reflect that commit-queue only skips testing. It never skips building. Although since the builds are incremental, they are usually fast.

Also deployed on production server.