Bug 209711 - REGRESSION (r258201): Use-after-move in UserMediaCaptureManager::Source::didFail()
Summary: REGRESSION (r258201): Use-after-move in UserMediaCaptureManager::Source::didF...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-28 19:19 PDT by David Kilzer (:ddkilzer)
Modified: 2020-03-28 20:03 PDT (History)
9 users (show)

See Also:

Attachments
Patch v1 (1.39 KB, patch)
2020-03-28 19:23 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-03-28 19:19:42 PDT 
Use-after-move in UserMediaCaptureManager::Source::didFail() of `errorMessage`:

    void didFail(String&& errorMessage)
    {
        m_isReady = true;
        m_errorMessage = WTFMove(errorMessage);
        if (m_callback)
            m_callback(String(errorMessage));
    }

This regressed in:

Bug 208816: Remove sync IPC when creating a remote capture source
<https://bugs.webkit.org/show_bug.cgi?id=208816>
<rdar://problem/60270112>
<https://trac.webkit.org/changeset/258201>
Comment 1 Radar WebKit Bug Importer 2020-03-28 19:20:06 PDT 
<rdar://problem/61018569>
Comment 2 David Kilzer (:ddkilzer) 2020-03-28 19:23:19 PDT 
Created attachment 394850 [details]
Patch v1
Comment 3 EWS 2020-03-28 20:03:04 PDT 
Committed r259172: <https://trac.webkit.org/changeset/259172>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394850 [details].