Bug 209794 - REGRESSION (r251574, r251600): _WKTextManipulationToken and _WKTextManipulationConfiguration are missing -dealloc
Summary: REGRESSION (r251574, r251600): _WKTextManipulationToken and _WKTextManipulati...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-30 20:06 PDT by David Kilzer (:ddkilzer)
Modified: 2020-03-30 22:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (2.20 KB, patch)
2020-03-30 20:15 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-03-30 20:06:26 PDT 
_WKTextManipulationToken and _WKTextManipulationConfiguration are missing -dealloc.


The clang static analyzer reports:


@implementation _WKTextManipulationToken

'_WKTextManipulationToken' lacks a 'dealloc' instance method but must release '_identifier' and others


@implementation _WKTextManipulationConfiguration

'_WKTextManipulationConfiguration' lacks a 'dealloc' instance method but must release '_exclusionRules'
Comment 1 David Kilzer (:ddkilzer) 2020-03-30 20:15:06 PDT 
Created attachment 395011 [details]
Patch v1
Comment 2 Radar WebKit Bug Importer 2020-03-30 20:15:50 PDT 
<rdar://problem/61087266>
Comment 3 Wenson Hsieh 2020-03-30 20:19:51 PDT 
Comment on attachment 395011 [details]
Patch v1

We usually solve this problem with RetainPtr, but this works too.
Comment 4 David Kilzer (:ddkilzer) 2020-03-30 21:21:39 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 395011 [details]
> Patch v1
> 
> We usually solve this problem with RetainPtr, but this works too.

After we switch to compiling with ARC, won't we just de-RetainPtr<> the class again because it's no longer necessary?
Comment 5 EWS 2020-03-30 22:23:02 PDT 
Committed r259280: <https://trac.webkit.org/changeset/259280>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395011 [details].