Bug 209915 - REGRESSION (r234685): Leak of CALayer in createCoreAnimationLayer() in PluginObjectMac.mm
Summary: REGRESSION (r234685): Leak of CALayer in createCoreAnimationLayer() in Plugin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 188245
Blocks:
  Show dependency tree / graph
 
Reported: 2020-04-02 11:27 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-02 12:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (1.84 KB, patch)
2020-04-02 11:29 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-02 11:27:11 PDT 
Leak of CALayer in createCoreAnimationLayer() in PluginObjectMac.mm.

CFTypeRef createCoreAnimationLayer()
{
    CALayer *caLayer = [[TestPluginLayer alloc] init];
    [...]
    return CFBridgingRetain(caLayer);
}

This function currently returns a +2 retained object instead of a +1 retained object.
Comment 1 David Kilzer (:ddkilzer) 2020-04-02 11:29:59 PDT 
Created attachment 395282 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-04-02 11:38:34 PDT 
This is also the _last_ static analyzer warning in DumpRenderTree for the version of the clang static analyzer we're running!
Comment 3 EWS 2020-04-02 12:16:12 PDT 
Committed r259403: <https://trac.webkit.org/changeset/259403>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395282 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-02 12:17:13 PDT 
<rdar://problem/61220322>