WebPageProxy::didCommitLoadForFrame should validate its `mimeType` parameter. <rdar://problem/60068700>
Created attachment 395423 [details] Patch v1
Looks like the mimeType parameter can be nil (nullptr) with these tests: TestWebKitAPI.WebKit.PendingAPIRequestURL TestWebKitAPI.WebKit.LoadDataWithNilMIMEType
(In reply to David Kilzer (:ddkilzer) from comment #2) > Looks like the mimeType parameter can be nil (nullptr) with these tests: > > TestWebKitAPI.WebKit.PendingAPIRequestURL > TestWebKitAPI.WebKit.LoadDataWithNilMIMEType The api-ios bot only shows this test failing: TestWebKitAPI.WebKit.LoadDataWithNilMIMEType
Created attachment 395751 [details] Patch v2
Committed r259729: <https://trac.webkit.org/changeset/259729> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395751 [details].
Comment on attachment 395751 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=395751&action=review > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:283 > + UNUSED_PARAM(mimeType); > + UNUSED_PARAM(useCustomContentProvider); Better to omit or comment out the argument names since that will give an error if we actually do use one, whereas if we use UNUSED_PARAM will keep compiling.
(In reply to Darin Adler from comment #6) > Comment on attachment 395751 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395751&action=review > > > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:283 > > + UNUSED_PARAM(mimeType); > > + UNUSED_PARAM(useCustomContentProvider); > > Better to omit or comment out the argument names since that will give an > error if we actually do use one, whereas if we use UNUSED_PARAM will keep > compiling. Committed r259750: <https://trac.webkit.org/changeset/259750>