Bug 210094 - VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`
Summary: VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-06 21:11 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-07 09:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (2.84 KB, patch)
2020-04-06 21:17 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (2.32 KB, patch)
2020-04-07 08:29 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-06 21:11:10 PDT
VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`.

messages -> VisitedLinkStore {
    AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, uint64_t linkHash)
}

using SharedStringHash = uint32_t;

void VisitedLinkStore::addVisitedLinkHashFromPage(WebPageProxyIdentifier pageProxyID, SharedStringHash linkHash)
{
    [...]
}

<rdar://problem/60334644>
Comment 1 David Kilzer (:ddkilzer) 2020-04-06 21:17:05 PDT
Created attachment 395651 [details]
Patch v1
Comment 2 Chris Dumez 2020-04-07 08:15:07 PDT
Comment on attachment 395651 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review

> Source/WebKit/Scripts/webkit/messages.py:618
> +        'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'],

Why is this needed? Seems like this would be the default.
Comment 3 David Kilzer (:ddkilzer) 2020-04-07 08:27:52 PDT
Comment on attachment 395651 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review

>> Source/WebKit/Scripts/webkit/messages.py:618
>> +        'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'],
> 
> Why is this needed? Seems like this would be the default.

Oops, it's not.  I'm new to this code.  Thanks!
Comment 4 David Kilzer (:ddkilzer) 2020-04-07 08:29:44 PDT
Created attachment 395685 [details]
Patch v2
Comment 5 EWS 2020-04-07 09:00:58 PDT
Committed r259637: <https://trac.webkit.org/changeset/259637>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395685 [details].