VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`. messages -> VisitedLinkStore { AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, uint64_t linkHash) } using SharedStringHash = uint32_t; void VisitedLinkStore::addVisitedLinkHashFromPage(WebPageProxyIdentifier pageProxyID, SharedStringHash linkHash) { [...] } <rdar://problem/60334644>
Created attachment 395651 [details] Patch v1
Comment on attachment 395651 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review > Source/WebKit/Scripts/webkit/messages.py:618 > + 'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'], Why is this needed? Seems like this would be the default.
Comment on attachment 395651 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review >> Source/WebKit/Scripts/webkit/messages.py:618 >> + 'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'], > > Why is this needed? Seems like this would be the default. Oops, it's not. I'm new to this code. Thanks!
Created attachment 395685 [details] Patch v2
Committed r259637: <https://trac.webkit.org/changeset/259637> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395685 [details].