Bug 210322 - Add WARN_UNUSED_RETURN to decode methods in WebCoreArgumentCoders
Summary: Add WARN_UNUSED_RETURN to decode methods in WebCoreArgumentCoders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-09 22:22 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-11 17:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch v1 (42.52 KB, patch)
2020-04-09 22:23 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-09 22:22:36 PDT 
Add WARN_UNUSED_RETURN to decode methods in WebCoreArgumentCoders.

No issues found.  This is to prevent future bugs from being introduced.
Comment 1 Radar WebKit Bug Importer 2020-04-09 22:22:47 PDT 
<rdar://problem/61565148>
Comment 2 David Kilzer (:ddkilzer) 2020-04-09 22:23:49 PDT 
Created attachment 396048 [details]
Patch v1
Comment 3 Darin Adler 2020-04-10 08:48:45 PDT 
Comment on attachment 396048 [details]
Patch v1

I see no reason to mark this bug security-sensitive.
Comment 4 David Kilzer (:ddkilzer) 2020-04-10 08:58:00 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 396048 [details]
> Patch v1
> 
> I see no reason to mark this bug security-sensitive.

It's a bit of a disinformation campaign.  I won't mark future ones as Security.
Comment 5 EWS 2020-04-10 09:03:46 PDT 
Committed r259875: <https://trac.webkit.org/changeset/259875>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396048 [details].
Comment 6 David Kilzer (:ddkilzer) 2020-04-11 16:57:34 PDT 
Follow-up fix:

Committed r259937: <https://trac.webkit.org/changeset/259937>