Bug 210414 - KeyedDecoder functions in ResourceLoadStatistics.{cpp,h} should return bool and use WARN_UNUSED_RETURN
Summary: KeyedDecoder functions in ResourceLoadStatistics.{cpp,h} should return bool a...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 212422 212424
Blocks: 210416 212423
  Show dependency treegraph
 
Reported: 2020-04-12 20:13 PDT by David Kilzer (:ddkilzer)
Modified: 2020-05-27 15:39 PDT (History)
10 users (show)

See Also:


Attachments
Patch v1 (13.66 KB, patch)
2020-04-12 20:18 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (deleted)
2020-05-27 13:07 PDT, David Kilzer (:ddkilzer)
no flags Details
Patch v4 (deleted)
2020-05-27 15:38 PDT, David Kilzer (:ddkilzer)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-12 20:13:22 PDT
KeyedDecoder functions in ResourceLoadStatistics.{cpp,h} should return bool and use WARN_UNUSED_RETURN.

Found via:
$ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebCore/loader/ResourceLoadStatistics.*
Comment 1 Radar WebKit Bug Importer 2020-04-12 20:14:00 PDT
<rdar://problem/61693118>
Comment 2 David Kilzer (:ddkilzer) 2020-04-12 20:18:48 PDT
Created attachment 396250 [details]
Patch v1
Comment 3 EWS 2020-04-13 10:41:48 PDT
Committed r260023: <https://trac.webkit.org/changeset/260023>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396250 [details].
Comment 4 Yusuke Suzuki 2020-05-27 11:36:46 PDT
Re-opened since this is blocked by bug 212422
Comment 5 David Kilzer (:ddkilzer) 2020-05-27 13:07:39 PDT
Created attachment 400368 [details]
Patch v2
Comment 6 David Kilzer (:ddkilzer) 2020-05-27 13:10:37 PDT
The content of attachment 400368 [details] has been deleted for the following reason:

Uploaded to wrong bug (was for Bug 212424).
Comment 7 David Kilzer (:ddkilzer) 2020-05-27 13:11:57 PDT
This will be fixed a different way in the future.
Comment 8 David Kilzer (:ddkilzer) 2020-05-27 15:38:40 PDT
Reopening to attach new patch.
Comment 9 David Kilzer (:ddkilzer) 2020-05-27 15:38:41 PDT
Created attachment 400393 [details]
Patch v4
Comment 10 David Kilzer (:ddkilzer) 2020-05-27 15:39:37 PDT
The content of attachment 400393 [details] has been deleted for the following reason:

Uploaded to wrong bug (was for Bug 212424).