Bug 210416 - Add WARN_UNUSED_RETURN to decode methods in Source/WebCore
Summary: Add WARN_UNUSED_RETURN to decode methods in Source/WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 210414
Blocks:
  Show dependency tree / graph
 
Reported: 2020-04-12 20:22 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-14 10:03 PDT (History)
31 users (show)

See Also:

Attachments
Patch v1 (50.04 KB, patch)
2020-04-12 20:30 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-12 20:22:16 PDT 
Add WARN_UNUSED_RETURN to decode methods in Source/WebCore.

Found via:
$ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebCore
Comment 1 David Kilzer (:ddkilzer) 2020-04-12 20:22:52 PDT 
NOTE: Not every change is relate to CoreIPC decoding, but they're all decode methods that return bool.
Comment 2 Radar WebKit Bug Importer 2020-04-12 20:25:11 PDT 
<rdar://problem/61693462>
Comment 3 David Kilzer (:ddkilzer) 2020-04-12 20:30:53 PDT 
Created attachment 396251 [details]
Patch v1
Comment 4 David Kilzer (:ddkilzer) 2020-04-12 20:31:29 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #3)
> Created attachment 396251 [details]
> Patch v1

I made some change to GTK files, so letting EWS run before requesting review.
Comment 5 David Kilzer (:ddkilzer) 2020-04-12 20:36:57 PDT 
Heh, this is blocked on Bug 210414 since that fixes a few issues found with these changes.
Comment 6 David Kilzer (:ddkilzer) 2020-04-13 07:39:03 PDT 
Note: No issues were found.  This is to add WARN_UNUSED_RETURN to decode methods returning `bool` to prevent future bugs.
Comment 7 David Kilzer (:ddkilzer) 2020-04-13 11:04:49 PDT 
Comment on attachment 396251 [details]
Patch v1

Obsoleting so I can repost the patch.  :(

Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit
Comment 8 David Kilzer (:ddkilzer) 2020-04-13 11:21:50 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #7)
> Comment on attachment 396251 [details]
> Patch v1
> 
> Obsoleting so I can repost the patch.  :(
> 
> Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit

Aakash marked the patch for retry by EWS, so now this patch is ready for review.
Comment 9 EWS 2020-04-14 10:03:31 PDT 
Committed r260078: <https://trac.webkit.org/changeset/260078>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396251 [details].