Bug 210423 - Add WARN_UNUSED_RETURN to decode methods in Source/WebKit
Summary: Add WARN_UNUSED_RETURN to decode methods in Source/WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-13 07:37 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-13 10:48 PDT (History)
14 users (show)

See Also:

Attachments
Patch v1 (61.72 KB, patch)
2020-04-13 07:44 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-13 07:37:33 PDT 
Add WARN_UNUSED_RETURN to decode methods in Source/WebKit.

Found via:
$ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebKit

NOTE: Not every change is relate to CoreIPC decoding, but they're all decode methods that return bool.

Also found a couple platformDecode() methods, so will update check-webkit-style.
Comment 1 Radar WebKit Bug Importer 2020-04-13 07:37:54 PDT 
<rdar://problem/61715582>
Comment 2 David Kilzer (:ddkilzer) 2020-04-13 07:38:52 PDT 
Note: No issues were found.  This is to add WARN_UNUSED_RETURN to decode methods returning `bool` to prevent future bugs.
Comment 3 David Kilzer (:ddkilzer) 2020-04-13 07:44:43 PDT 
Created attachment 396273 [details]
Patch v1
Comment 4 EWS 2020-04-13 10:48:28 PDT 
Committed r260025: <https://trac.webkit.org/changeset/260025>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396273 [details].