Bug 210459 - check-webkit-style should warn about attributes that appear after function definitions
Summary: check-webkit-style should warn about attributes that appear after function de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-13 15:06 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-13 17:33 PDT (History)
6 users (show)

See Also:


Attachments
Patch v1 (4.87 KB, patch)
2020-04-13 15:14 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-13 15:06:32 PDT
check-webkit-style should warn about attributes that appear after function definitions.

Darin suggested it was better to be consistent and always put attributes before the function definition since placing them after the function definition (e.g., in a static function with no predeclaration) doesn't work.
Comment 1 David Kilzer (:ddkilzer) 2020-04-13 15:14:41 PDT
Created attachment 396339 [details]
Patch v1
Comment 2 EWS 2020-04-13 17:32:30 PDT
Committed r260051: <https://trac.webkit.org/changeset/260051>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396339 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-13 17:33:15 PDT
<rdar://problem/61747702>