Bug 211276 - REGRESSION (r260214): Leak of _WKTextInputContext in -[WKContentView _isTextInputContextFocused:]
Summary: REGRESSION (r260214): Leak of _WKTextInputContext in -[WKContentView _isTextI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 210611
Blocks:
  Show dependency tree / graph
 
Reported: 2020-04-30 20:19 PDT by David Kilzer (:ddkilzer)
Modified: 2020-05-01 03:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (2.29 KB, patch)
2020-04-30 20:21 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-30 20:19:09 PDT 
Leak of _WKTextInputContext in -[WKContentView _isTextInputContextFocused:].

Found by clang static analyzer.

Regressed in:

    [iOS] Add a way to focus a text input and place a caret
    <https://bugs.webkit.org/show_bug.cgi?id=210611>
    <rdar://problem/61893062>
    <https://trac.webkit.org/r260214>
Comment 1 Radar WebKit Bug Importer 2020-04-30 20:19:24 PDT 
<rdar://problem/62696724>
Comment 2 David Kilzer (:ddkilzer) 2020-04-30 20:21:37 PDT 
Created attachment 398151 [details]
Patch v1
Comment 3 Daniel Bates 2020-04-30 20:35:57 PDT 
Comment on attachment 398151 [details]
Patch v1

Patch looks good. What a silly mistake.
Comment 4 David Kilzer (:ddkilzer) 2020-04-30 20:37:34 PDT 
(In reply to Daniel Bates from comment #3)
> Comment on attachment 398151 [details]
> Patch v1
> 
> Patch looks good. What a silly mistake.

Would have been fine with ARC.  Someday we'll have nice things. :)
Comment 5 EWS 2020-05-01 03:26:37 PDT 
Committed r260994: <https://trac.webkit.org/changeset/260994>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398151 [details].