Bug 211322 - [IPC hardening] Refactor createMessageDecoder() for clarity
Summary: [IPC hardening] Refactor createMessageDecoder() for clarity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 211260
Blocks:
  Show dependency tree / graph
 
Reported: 2020-05-01 14:34 PDT by David Kilzer (:ddkilzer)
Modified: 2020-05-01 16:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch for landing (3.69 KB, patch)
2020-05-01 15:20 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-05-01 14:34:06 PDT 
Refactor createMessageDecoder() for clarity.

Follow-on based on review comments from Bug 211260.
Comment 1 David Kilzer (:ddkilzer) 2020-05-01 15:20:44 PDT 
Created attachment 398248 [details]
Patch for landing
Comment 2 David Kilzer (:ddkilzer) 2020-05-01 15:21:44 PDT 
Comment on attachment 398248 [details]
Patch for landing

This change wes reviewed by Darin in Bug 211260.
Comment 3 David Kilzer (:ddkilzer) 2020-05-01 15:23:11 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Comment on attachment 398248 [details]
> Patch for landing
> 
> This change wes reviewed by Darin in Bug 211260.

Commit queue tested this patch in Bug 211260 Attachment #398214 [details].
Comment 4 David Kilzer (:ddkilzer) 2020-05-01 15:24:13 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #3)
> (In reply to David Kilzer (:ddkilzer) from comment #2)
> > Comment on attachment 398248 [details]
> > Patch for landing
> > 
> > This change wes reviewed by Darin in Bug 211260.
> 
> Commit queue tested this patch in Bug 211260 Attachment #398214 [details].

Commit queue => EWS.
Comment 5 Radar WebKit Bug Importer 2020-05-01 15:25:25 PDT 
<rdar://problem/62749634>
Comment 6 David Kilzer (:ddkilzer) 2020-05-01 15:53:23 PDT 
Of course someone broke the build just as I uploaded the patch:

  "WebCore::Page::setCORSDisablingPatterns(WTF::Vector<WebCore::UserContentURLPattern, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)", referenced from:
      WebKit::WebPage::updateCORSDisablingPatterns(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&) in WebPage.o
ld: symbol(s) not found for architecture x86_64
Comment 7 EWS 2020-05-01 16:44:52 PDT 
Committed r261040: <https://trac.webkit.org/changeset/261040>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398248 [details].