Bug 212827 - [IPC] Adopt enum class for PluginLoadClientPolicy
Summary: [IPC] Adopt enum class for PluginLoadClientPolicy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 211988
  Show dependency tree / graph
 
Reported: 2020-06-05 08:43 PDT by David Kilzer (:ddkilzer)
Modified: 2020-06-05 13:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (26.51 KB, patch)
2020-06-05 09:39 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (26.79 KB, patch)
2020-06-05 10:32 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-06-05 08:43:28 PDT 
Adopt enum class for PluginLoadClientPolicy.

Also add EnumTraits< WebCore::PluginLoadClientPolicy > since this type is used via IPC, and replace uint8_t with more strongly typed WebCore::PluginLoadClientPolicy.
Comment 1 David Kilzer (:ddkilzer) 2020-06-05 08:46:32 PDT 
<rdar://problem/64030431>
Comment 2 David Kilzer (:ddkilzer) 2020-06-05 09:39:45 PDT 
Created attachment 401163 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2020-06-05 09:47:19 PDT 
Comment on attachment 401163 [details]
Patch v1

Wee!  Build failures.
Comment 4 David Kilzer (:ddkilzer) 2020-06-05 10:32:51 PDT 
Created attachment 401172 [details]
Patch v2
Comment 5 David Kilzer (:ddkilzer) 2020-06-05 13:06:36 PDT 
Comment on attachment 401172 [details]
Patch v2

Adding cq+ since the Windows layout test failure and the api-ios test failure don't seem to be related to this patch.
Comment 6 EWS 2020-06-05 13:15:13 PDT 
Committed r262648: <https://trac.webkit.org/changeset/262648>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401172 [details].