Bug 212870 - [IPC] Adopt enum class for DragOperation
Summary: [IPC] Adopt enum class for DragOperation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 212605
Blocks: 211988
  Show dependency tree / graph
 
Reported: 2020-06-06 09:25 PDT by David Kilzer (:ddkilzer)
Modified: 2020-06-11 13:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (37.14 KB, patch)
2020-06-06 09:43 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (37.92 KB, patch)
2020-06-06 11:30 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-06-06 09:25:15 PDT 
Adopt enum class for DragOperation.
Comment 1 Radar WebKit Bug Importer 2020-06-06 09:25:32 PDT 
<rdar://problem/64069940>
Comment 2 David Kilzer (:ddkilzer) 2020-06-06 09:43:29 PDT 
Created attachment 401264 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2020-06-06 11:30:35 PDT 
Created attachment 401270 [details]
Patch v2
Comment 4 David Kilzer (:ddkilzer) 2020-06-06 11:31:00 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #3)
> Created attachment 401270 [details]
> Patch v2

Removed FIXME in Source/WebKit/Scripts/webkit/messages.py.
Comment 5 David Kilzer (:ddkilzer) 2020-06-08 09:34:23 PDT 
Comment on attachment 401270 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=401270&action=review

Ready for review.  I called out non-mechanical changes via comments.

> Source/WebCore/ChangeLog:19
> +        * page/DragActions.h:
> +        (WebCore::DragOperation):
> +        - Convert to enum class.

This is not a mechanical change.

> Source/WebKit/ChangeLog:10
> +        * Scripts/webkit/messages.py:
> +        - Remove FIXME now that it's not needed.

This is not a mechanical change.

> Tools/ChangeLog:10
> +        * Scripts/do-webcore-rename:
> +        - Do DragOperation renames.

Not a mechanical change.  (Do we normally update the script like this?)
Comment 6 Darin Adler 2020-06-08 11:20:22 PDT 
Comment on attachment 401270 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=401270&action=review

>> Tools/ChangeLog:10
>> +        - Do DragOperation renames.
> 
> Not a mechanical change.  (Do we normally update the script like this?)

We do; it’s fine.
Comment 7 EWS 2020-06-08 13:07:05 PDT 
Committed r262735: <https://trac.webkit.org/changeset/262735>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401270 [details].