Add nullptr checks for WebPage::m_activeColorChooser. WebPage::m_activeColorChooser is a pointer that's initialized to nullptr, so it is not always set. <rdar://problem/65850975>
Created attachment 405077 [details] Patch v1
Comment on attachment 405077 [details] Patch v1 Not clear what this has to do with IPC. Also, are there eventually test cases coming for this?
(In reply to Darin Adler from comment #2) > Comment on attachment 405077 [details] > Patch v1 > > Not clear what this has to do with IPC. Also, are there eventually test > cases coming for this? Replied in radar.
(In reply to David Kilzer (:ddkilzer) from comment #3) > (In reply to Darin Adler from comment #2) > > Comment on attachment 405077 [details] > > Patch v1 > > > > Not clear what this has to do with IPC. Also, are there eventually test > > cases coming for this? > > Replied in radar. Filed this to track adding a test case: Bug 214748: Add test case for nullptr checks in WebPage::m_activeColorChooser <https://bugs.webkit.org/show_bug.cgi?id=214748> This has to do with IPC since nullptr deref crashes can be hit in WebPage when sending unexpected IPC messages.
Committed r264842: <https://trac.webkit.org/changeset/264842> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405077 [details].