Bug 216092 - REGRESSION (r237835): WebCore::TextDecorationThickness constructor fails to initialize m_length
Summary: REGRESSION (r237835): WebCore::TextDecorationThickness constructor fails to i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 191242
Blocks:
  Show dependency tree / graph
 
Reported: 2020-09-02 13:10 PDT by David Kilzer (:ddkilzer)
Modified: 2020-09-03 10:23 PDT (History)
10 users (show)

See Also:

Attachments
Patch v1 (1.62 KB, patch)
2020-09-02 13:11 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-09-02 13:10:15 PDT 
WebCore::TextDecorationThickness constructor fails to initialize m_length.

Regressed here:

    Bug 191242: Parsing support for text-underline-offset and text-decoration-thickness
    <https://bugs.webkit.org/show_bug.cgi?id=191242>
    <https://trac.webkit.org/r237835>

Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker.
Comment 1 David Kilzer (:ddkilzer) 2020-09-02 13:11:08 PDT 
Created attachment 407792 [details]
Patch v1
Comment 2 Tim Horton 2020-09-02 13:13:24 PDT 
Comment on attachment 407792 [details]
Patch v1

Technically there is no path there, but I guess it doesn't hurt?
Comment 3 David Kilzer (:ddkilzer) 2020-09-02 13:41:46 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 407792 [details]
> Patch v1
> 
> Technically there is no path there, but I guess it doesn't hurt?

Yes. this is a hardening fix.
Comment 4 David Kilzer (:ddkilzer) 2020-09-03 10:06:18 PDT 
Comment on attachment 407792 [details]
Patch v1

Adding cq+ since failures in fast/block/margin-collapse/103.html are happening across multiple patches.  Not related to this patch.
Comment 5 EWS 2020-09-03 10:22:31 PDT 
Committed r266531: <https://trac.webkit.org/changeset/266531>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407792 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-03 10:23:15 PDT 
<rdar://problem/68287137>