Bug 216271 - Add an experimental feature flag for CSS individual transform properties
Summary: Add an experimental feature flag for CSS individual transform properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 178117
  Show dependency treegraph
 
Reported: 2020-09-08 03:53 PDT by Antoine Quint
Modified: 2020-09-25 14:26 PDT (History)
16 users (show)

See Also:


Attachments
Patch (14.65 KB, patch)
2020-09-08 04:04 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (29.20 KB, patch)
2020-09-08 09:07 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (14.26 KB, patch)
2020-09-25 01:51 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (14.28 KB, patch)
2020-09-25 07:14 PDT, Antoine Quint
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.21 KB, patch)
2020-09-25 08:29 PDT, Antoine Quint
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.30 KB, patch)
2020-09-25 09:49 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (14.21 KB, patch)
2020-09-25 10:01 PDT, Antoine Quint
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.30 KB, patch)
2020-09-25 11:21 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (14.14 KB, patch)
2020-09-25 11:40 PDT, Antoine Quint
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.66 KB, patch)
2020-09-25 12:13 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (14.77 KB, patch)
2020-09-25 13:33 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (14.70 KB, patch)
2020-09-25 13:36 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-09-08 03:53:51 PDT
Add an experimental feature flag for CSS individual transform properties
Comment 1 Antoine Quint 2020-09-08 04:04:29 PDT
Created attachment 408222 [details]
Patch
Comment 2 youenn fablet 2020-09-08 04:49:09 PDT
Comment on attachment 408222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408222&action=review

> Source/WebKit/Shared/WebPreferences.yaml:2167
> +  webcoreBinding: RuntimeEnabledFeatures

Can it be made a Settings instead of RuntimeEnabledFeatures? Is it something that can be queried from background threads?
Comment 3 Antoine Quint 2020-09-08 09:07:26 PDT
Created attachment 408231 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2020-09-15 03:54:16 PDT
<rdar://problem/68914539>
Comment 5 Antoine Quint 2020-09-25 01:51:39 PDT
Created attachment 409669 [details]
Patch
Comment 6 Antoine Quint 2020-09-25 01:52:22 PDT
(In reply to youenn fablet from comment #2)
> Comment on attachment 408222 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408222&action=review
> 
> > Source/WebKit/Shared/WebPreferences.yaml:2167
> > +  webcoreBinding: RuntimeEnabledFeatures
> 
> Can it be made a Settings instead of RuntimeEnabledFeatures? Is it something
> that can be queried from background threads?

The newer patch has the flag backed by a setting.
Comment 7 Dean Jackson 2020-09-25 02:09:16 PDT
Comment on attachment 409669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409669&action=review

> Source/WebCore/page/Settings.yaml:1125
> +cssIndividualTransformPropertiesEnabled:
> +  initial: false

Why not make this a runtime flag?
Comment 8 Antoine Quint 2020-09-25 02:28:27 PDT
(In reply to Dean Jackson from comment #7)
> Comment on attachment 409669 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409669&action=review
> 
> > Source/WebCore/page/Settings.yaml:1125
> > +cssIndividualTransformPropertiesEnabled:
> > +  initial: false
> 
> Why not make this a runtime flag?

Did you mean a runtime-enabled feature? I think we want to do this only for process-wide flags, and this feature does not require one. See Youenn's comments above.
Comment 9 Antoine Quint 2020-09-25 07:14:06 PDT
Created attachment 409689 [details]
Patch
Comment 10 Antoine Quint 2020-09-25 08:29:20 PDT
Created attachment 409696 [details]
Patch
Comment 11 Antoine Quint 2020-09-25 09:49:02 PDT
Created attachment 409700 [details]
Patch
Comment 12 Antoine Quint 2020-09-25 10:01:25 PDT
Created attachment 409701 [details]
Patch
Comment 13 Antoine Quint 2020-09-25 11:21:49 PDT
Created attachment 409712 [details]
Patch
Comment 14 Antoine Quint 2020-09-25 11:40:12 PDT
Created attachment 409714 [details]
Patch
Comment 15 Antoine Quint 2020-09-25 12:13:55 PDT
Created attachment 409718 [details]
Patch
Comment 16 Antoine Quint 2020-09-25 13:33:46 PDT
Created attachment 409731 [details]
Patch for landing
Comment 17 Antoine Quint 2020-09-25 13:36:29 PDT
Created attachment 409732 [details]
Patch for landing
Comment 18 EWS 2020-09-25 14:26:33 PDT
Committed r267592: <https://trac.webkit.org/changeset/267592>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409732 [details].