Bug 216729 - [WebIDL] Split up Performance.idl into component partials
Summary: [WebIDL] Split up Performance.idl into component partials
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-19 10:29 PDT by Sam Weinig
Modified: 2020-09-22 08:29 PDT (History)
10 users (show)

See Also:

Attachments
Patch (17.12 KB, patch)
2020-09-19 10:33 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.16 KB, patch)
2020-09-19 10:34 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (17.48 KB, patch)
2020-09-19 11:04 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (17.21 KB, patch)
2020-09-22 06:08 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.21 KB, patch)
2020-09-22 06:31 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-19 10:29:21 PDT 
[WebIDL] Split up Performance.idl into component partials
Comment 1 Sam Weinig 2020-09-19 10:33:18 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-19 10:34:53 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-19 11:04:33 PDT 
Created attachment 409205 [details]
Patch
Comment 4 Sam Weinig 2020-09-19 11:07:57 PDT 
Reviewers, curious to hear feedback on the new naming scheme for this partial supplements. e.g. Performance+UserTiming.idl, etc.

The benefits as I see them are making it clear to someone looking for all the components of a interface and not conflicting with existing interface names (for instance, there is already an interface called PerformanceResourceTiming).
Comment 5 Sam Weinig 2020-09-20 13:20:46 PDT 
Anyone want to review?
Comment 6 Darin Adler 2020-09-21 09:51:00 PDT 
Comment on attachment 409205 [details]
Patch

I like these names with + I think.
Comment 7 Sam Weinig 2020-09-22 06:08:57 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-09-22 06:31:44 PDT 
Created attachment 409357 [details]
Patch
Comment 9 EWS 2020-09-22 08:28:36 PDT 
Committed r267408: <https://trac.webkit.org/changeset/267408>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409357 [details].
Comment 10 Radar WebKit Bug Importer 2020-09-22 08:29:17 PDT 
<rdar://problem/69371924>