Bug 221521 - WebCore::genericFamily() should use checked_cf_cast<>
Summary: WebCore::genericFamily() should use checked_cf_cast<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-06 11:16 PST by David Kilzer (:ddkilzer)
Modified: 2021-02-10 18:26 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (1.85 KB, patch)
2021-02-06 11:18 PST, David Kilzer (:ddkilzer) 		sam: review+
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (1.82 KB, patch)
2021-02-10 17:35 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-02-06 11:16:09 PST 
WebCore::genericFamily() should use static_cf_cast<>.

See notes in Bug 221428 Comment #0:
<https://bugs.webkit.org/show_bug.cgi?id=221428#c0>
Comment 1 David Kilzer (:ddkilzer) 2021-02-06 11:18:26 PST 
Created attachment 419512 [details]
Patch v1
Comment 2 Sam Weinig 2021-02-07 10:05:41 PST 
Comment on attachment 419512 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=419512&action=review

> Source/WebCore/ChangeLog:10
> +        - Switch from dynamic_cf_cast<> to static_cf_cast<> because we

Looks like you actually use checked_cf_cast. Probably want to update the ChangeLog comment and title.
Comment 3 David Kilzer (:ddkilzer) 2021-02-08 11:53:00 PST 
Comment on attachment 419512 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=419512&action=review

>> Source/WebCore/ChangeLog:10
>> +        - Switch from dynamic_cf_cast<> to static_cf_cast<> because we
> 
> Looks like you actually use checked_cf_cast. Probably want to update the ChangeLog comment and title.

Ha!  This is what happens when I write patches on the weekend now.  :)  Thanks for catching.
Comment 4 David Kilzer (:ddkilzer) 2021-02-10 17:35:09 PST 
Created attachment 419929 [details]
Patch for landing
Comment 5 EWS 2021-02-10 18:25:09 PST 
Committed r272700: <https://commits.webkit.org/r272700>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419929 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-10 18:26:32 PST 
<rdar://problem/74216540>