Bug 221734 - Remove unused WebKit::LocalStorageDatabaseTracker::deleteAllDatabases()
Summary: Remove unused WebKit::LocalStorageDatabaseTracker::deleteAllDatabases()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 17:51 PST by David Kilzer (:ddkilzer)
Modified: 2021-02-11 18:46 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (3.15 KB, patch)
2021-02-11 10:58 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-02-10 17:51:03 PST
WebCore::SQLiteFileSystem::deleteEmptyDatabaseDirectory() in Source/WebCore/platform/sql/SQLiteFileSystem.h needs to be marked as WEBCORE_EXPORT so that it can be used in WebKit::LocalStorageDatabaseTracker::deleteAllDatabases() from Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp in WebKit.framework.

This probably hasn't been found before since WebKit.framework has dead code stripping unconditionally enabled via Source/WebKit/Configurations/Base.xcconfig:

// Dead code stripping needs to be on in the debug variant to avoid link errors.  This is due to unconditionally
// building the MiG bindings for WebKitPluginClient even when the functions that the bindings wrap are not built.
DEAD_CODE_STRIPPING = YES;

Most other WebKit projects disable dead code stripping in Debug builds like this:

DEAD_CODE_STRIPPING = YES;
DEAD_CODE_STRIPPING[config=Debug] = NO;

I guess this also means that LocalStorageDatabaseTracker::deleteAllDatabases() is dead code.

Maybe we can just delete LocalStorageDatabaseTracker::deleteAllDatabases() instead?
Comment 1 David Kilzer (:ddkilzer) 2021-02-10 18:40:56 PST
<rdar://problem/74215959>
Comment 2 David Kilzer (:ddkilzer) 2021-02-11 10:58:39 PST
Created attachment 420004 [details]
Patch v1
Comment 3 Alexey Proskuryakov 2021-02-11 11:46:28 PST
Comment on attachment 420004 [details]
Patch v1

Best kind of patch.
Comment 4 EWS 2021-02-11 14:57:40 PST
Committed r272754: <https://commits.webkit.org/r272754>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420004 [details].