Bug 222054 - Remove missing files from WebKit Xcode project
Summary: Remove missing files from WebKit Xcode project
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 188754
Blocks:
  Show dependency tree / graph
 
Reported: 2021-02-17 11:00 PST by David Kilzer (:ddkilzer)
Modified: 2021-02-18 06:09 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (16.46 KB, patch)
2021-02-17 11:22 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-02-17 11:00:09 PST 
Remove missing files from WebKit Xcode project.

Some cruft has built up since the last time I ran `tidy-Xcode-project-file --missing` from Bug 188754.

$ ./Tools/Scripts/tidy-Xcode-project-file --missing Source/WebKit/WebKit.xcodeproj
Reading project file Source/WebKit/WebKit.xcodeproj...
Searching for missing references to files and groups...
  MISSING: File or folder "NetworkCacheFileSystemCocoa.mm" is missing at path: Source/WebKit/NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm
  MISSING: File or folder "ImageDataReference.h" is missing at path: Source/WebKit/Platform/IPC/ImageDataReference.h
  MISSING: File or folder "WebRTCSocket.messages.in" is missing at path: Source/WebKit/WebProcess/Network/webrtc/WebRTCSocket.messages.in
  MISSING: File or folder "WebRTCSocket.h" is missing at path: Source/WebKit/WebProcess/Network/webrtc/WebRTCSocket.h
  MISSING: File or folder "WebRTCSocket.cpp" is missing at path: Source/WebKit/WebProcess/Network/webrtc/WebRTCSocket.cpp
  MISSING: File or folder "ConcreteShareableImageBuffer.h" is missing at path: Source/WebKit/Shared/ConcreteShareableImageBuffer.h
WARNING: Found 6 missing references at ./Tools/Scripts/tidy-Xcode-project-file line 163.
Done.

See:

Bug 188754: Tool to fix folders that should map to directories in Xcode project files
<https://bugs.webkit.org/show_bug.cgi?id=188754>
Comment 1 David Kilzer (:ddkilzer) 2021-02-17 11:22:41 PST 
Created attachment 420682 [details]
Patch v1
Comment 2 EWS 2021-02-17 13:38:24 PST 
Committed r273025: <https://commits.webkit.org/r273025>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420682 [details].
Comment 3 Radar WebKit Bug Importer 2021-02-17 13:39:14 PST 
<rdar://problem/74448028>
Comment 4 Kimmo Kinnunen 2021-02-18 06:09:20 PST 
Nice! Hope to see the tool in check-webkit-style so I don't make same mistake so often :)