Bug 226562 - Weak external symbols found when building with Release+Coverage configuration
Summary: Weak external symbols found when building with Release+Coverage configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 206686
Blocks: 226668 226684 228063
  Show dependency tree / graph
 
Reported: 2021-06-02 17:26 PDT by David Kilzer (:ddkilzer)
Modified: 2021-07-18 13:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (4.01 KB, patch)
2021-06-02 17:30 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-06-02 17:26:37 PDT 
Weak external symbols found when building with Release+Coverage configuration:

PhaseScriptExecution Check\ For\ Weak\ VTables\ and\ Externals JavaScriptCore.build/Release/JavaScriptCore.build/Script-5D29D8BE0E9860B400C3D2D0.sh
    cd OpenSource/Source/JavaScriptCore
    /bin/sh -c JavaScriptCore.build/Release/JavaScriptCore.build/Script-5D29D8BE0E9860B400C3D2D0.sh
ERROR: JavaScriptCore has a weak external symbol in it (Release/JavaScriptCore.framework/Versions/A/JavaScriptCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol ___llvm_profile_filename
ERROR: symbol ___llvm_profile_raw_version
ERROR: symbol _lprofDirMode
Command /bin/sh failed with exit code 1

<rdar://problem/78765608>
Comment 1 David Kilzer (:ddkilzer) 2021-06-02 17:30:27 PDT 
Created attachment 430423 [details]
Patch v1
Comment 2 EWS 2021-06-03 19:21:05 PDT 
Committed r278444 (238464@main): <https://commits.webkit.org/238464@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430423 [details].
Comment 3 David Kilzer (:ddkilzer) 2021-06-04 08:56:49 PDT 
Follow-up build fix for coverage+release builds due to weak external symbol:

    REGRESSION (r278121): Fix build failure due to weak external symbol

Committed r278461 (278461@main): <https://commits.webkit.org/278461@main>