Bug 227477 - xhr.send(URLSearchParams) should align default Content-Type header field with Chrome and Firefox
Summary: xhr.send(URLSearchParams) should align default Content-Type header field with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-28 22:44 PDT by Alex Christensen
Modified: 2021-06-29 14:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.99 KB, patch)
2021-06-28 22:45 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (17.16 KB, patch)
2021-06-29 10:01 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-06-28 22:44:23 PDT 
xhr.send(URLSearchParams) should align default Content-Type header field with Chrome and Firefox
Comment 1 Alex Christensen 2021-06-28 22:45:39 PDT 
Created attachment 432453 [details]
Patch
Comment 2 Alex Christensen 2021-06-29 10:01:27 PDT 
Created attachment 432492 [details]
Patch
Comment 3 Chris Dumez 2021-06-29 10:03:11 PDT 
Comment on attachment 432492 [details]
Patch

r=me
Comment 4 EWS 2021-06-29 12:07:50 PDT 
Committed r279380 (239245@main): <https://commits.webkit.org/239245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432492 [details].
Comment 5 Radar WebKit Bug Importer 2021-06-29 12:08:31 PDT 
<rdar://problem/79927791>
Comment 6 Alexey Proskuryakov 2021-06-29 14:53:37 PDT 
Comment on attachment 432492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432492&action=review

> LayoutTests/imported/w3c/web-platform-tests/xhr/setrequestheader-content-type-expected.txt:-34
> -PASS ReadableStream request respects setRequestHeader("")
> -FAIL ReadableStream request with under type sends no Content-Type without setRequestHeader() call assert_equals: expected "" but got "Content-Type: text/plain;charset=UTF-8\n"
> -FAIL ReadableStream request keeps setRequestHeader() Content-Type and charset assert_equals: expected "Content-Type: application/xml;charset=ASCII\n" but got "Content-Type: application/xml;charset=UTF-8\n"

I'm curious about how these lines disappeared.
Comment 7 Alex Christensen 2021-06-29 14:55:08 PDT 
The test had been marked as failing, then updated, and nobody noticed those tests were removed.