Bug 228063 - Ignore weak external symbols in clang coverage builds using check-for-weak-vtables-and-externals
Summary: Ignore weak external symbols in clang coverage builds using check-for-weak-vt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 226562 226684
Blocks:
  Show dependency tree / graph
 
Reported: 2021-07-18 13:04 PDT by David Kilzer (:ddkilzer)
Modified: 2021-07-18 18:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (2.56 KB, patch)
2021-07-18 13:13 PDT, David Kilzer (:ddkilzer) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-07-18 13:04:53 PDT 
Ignore weak external symbols in clang coverage builds using check-for-weak-vtables-and-externals.

It turns out that -exported_symbol and -unexported_symbol can't be used together when linking:

    ld: can't use -unexported_symbol and -exported_symbol
    clang: error: linker command failed with exit code 1 (use -v to see invocation)

So go back to the solution from Bug 226562 (effectively reverting the change for Bug 226684).

<rdar://problem/80477138>
Comment 1 David Kilzer (:ddkilzer) 2021-07-18 13:13:59 PDT 
Created attachment 433757 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2021-07-18 13:15:10 PDT 
Note that the libwebrtc project was the first project failing with a coverage build before this change.
Comment 3 EWS 2021-07-18 15:59:35 PDT 
Committed r280021 (239763@main): <https://commits.webkit.org/239763@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433757 [details].