Bug 231830 - _WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
Summary: _WKRemoteWebInspectorViewController leaks an instance variable and should use...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-15 14:06 PDT by David Kilzer (:ddkilzer)
Modified: 2021-10-16 20:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (2.85 KB, patch)
2021-10-15 14:16 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (2.81 KB, patch)
2021-10-15 14:29 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-10-15 14:06:43 PDT 
_WKRemoteWebInspectorViewController leaks its instance variables and should use a weak delegate.

Leaks found by clang static analyzer.
Comment 1 Radar WebKit Bug Importer 2021-10-15 14:07:02 PDT 
<rdar://problem/84316056>
Comment 2 David Kilzer (:ddkilzer) 2021-10-15 14:16:05 PDT 
Created attachment 441426 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2021-10-15 14:27:36 PDT 
Comment on attachment 441426 [details]
Patch v1

Oops, didn't see the implementation of -webView and -window.
Comment 4 David Kilzer (:ddkilzer) 2021-10-15 14:29:49 PDT 
Created attachment 441428 [details]
Patch v2
Comment 5 David Kilzer (:ddkilzer) 2021-10-16 20:37:58 PDT 
Comment on attachment 441428 [details]
Patch v2

Adding cq+ since api-gtk failures are unrelated.
Comment 6 EWS 2021-10-16 20:58:59 PDT 
Committed r284329 (243124@main): <https://commits.webkit.org/243124@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441428 [details].