Bug 231902 - Fix leak of CGColorSpaceRef in FilterEffectRendererCoreImage::sharedCIContext()
Summary: Fix leak of CGColorSpaceRef in FilterEffectRendererCoreImage::sharedCIContext()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 213673
Blocks:
  Show dependency treegraph
 
Reported: 2021-10-18 09:46 PDT by David Kilzer (:ddkilzer)
Modified: 2021-10-19 12:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch v1 (2.25 KB, patch)
2021-10-18 09:49 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-10-18 09:46:17 PDT
Fix leak of CGColorSpaceRef in FilterEffectRendererCoreImage::sharedCIContext().

Found by clang static analyzer.
Comment 1 Radar WebKit Bug Importer 2021-10-18 09:46:28 PDT
<rdar://problem/84375203>
Comment 2 David Kilzer (:ddkilzer) 2021-10-18 09:49:02 PDT
Created attachment 441619 [details]
Patch v1
Comment 3 Wenson Hsieh 2021-10-18 09:50:02 PDT
Comment on attachment 441619 [details]
Patch v1

Good catch!

r=mews
Comment 4 David Kilzer (:ddkilzer) 2021-10-19 12:52:28 PDT
Comment on attachment 441619 [details]
Patch v1

Took a little over a day, but everything is green now, so adding cq+.
Comment 5 EWS 2021-10-19 12:56:20 PDT
Committed r284481 (243240@main): <https://commits.webkit.org/243240@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441619 [details].