Bug 231927 - WebPDFViewPlaceholder should use a weak delegate
Summary: WebPDFViewPlaceholder should use a weak delegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-18 18:00 PDT by David Kilzer (:ddkilzer)
Modified: 2021-10-20 12:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (2.42 KB, patch)
2021-10-18 18:01 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-10-18 18:00:18 PDT 
WebPDFViewPlaceholder should use a weak delegate.
Comment 1 David Kilzer (:ddkilzer) 2021-10-18 18:01:30 PDT 
Created attachment 441665 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2021-10-20 11:49:41 PDT 
Comment on attachment 441665 [details]
Patch v1

Marking cq+ since ios-wk2 won't test this (this affects iOS WK1), and api-ios may not test it either (I don't see any WK1 PDF tests in Tools/TestWebKitAPI/Tests).

Both bots are also 8 or 24 hours behind, and any behavior change here would be changing a flakey crashing test into a flakey failing test, so this would likely only need a test expectation update.
Comment 3 EWS 2021-10-20 11:59:30 PDT 
Committed r284559 (243301@main): <https://commits.webkit.org/243301@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441665 [details].
Comment 4 Radar WebKit Bug Importer 2021-10-20 12:00:22 PDT 
<rdar://problem/84473142>