Bug 232358 - [ANGLE] Enable -Wformat=2 warnings
Summary: [ANGLE] Enable -Wformat=2 warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-26 19:03 PDT by David Kilzer (:ddkilzer)
Modified: 2021-11-01 06:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (3.38 KB, patch)
2021-10-26 19:14 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (3.37 KB, patch)
2021-10-27 18:06 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-10-26 19:03:19 PDT 
Enable -Wformat=2 warnings in the ANGLE project.

This includes -Wformat-nonliteral among other warnings.

<rdar://problem/84568935>
Comment 1 David Kilzer (:ddkilzer) 2021-10-26 19:14:12 PDT 
Created attachment 442555 [details]
Patch v1
Comment 2 EWS Watchlist 2021-10-26 19:15:01 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-10-26 22:39:51 PDT 
It would be most beneficial to add this upstream in ANGLE in https://chromium.googlesource.com/angle/angle . We're actively in the process of upstreaming all of Apple's changes in preparation for taking a new ANGLE snapshot.

Kyle (CC'd) can also help with this.
Comment 4 David Kilzer (:ddkilzer) 2021-10-27 00:30:00 PDT 
(In reply to Kenneth Russell from comment #3)
> It would be most beneficial to add this upstream in ANGLE in
> https://chromium.googlesource.com/angle/angle . We're actively in the
> process of upstreaming all of Apple's changes in preparation for taking a
> new ANGLE snapshot.
> 
> Kyle (CC'd) can also help with this.

Yep, I filed <https://bugs.chromium.org/p/angleproject/issues/detail?id=6623> to track upstreaming.  It’s in the See Also field as well.
Comment 5 David Kilzer (:ddkilzer) 2021-10-27 18:06:54 PDT 
Created attachment 442661 [details]
Patch v2
Comment 6 David Kilzer (:ddkilzer) 2021-10-27 18:07:39 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #5)
> Created attachment 442661 [details]
> Patch v2

Use `constexpr const char *` instead of `const char *const`.
Comment 7 David Kilzer (:ddkilzer) 2021-10-29 10:11:39 PDT 
Adding Simon and Jon since I don't know who's reviewing ANGLE patches these days.

This is a pretty simple patch.
Comment 8 EWS 2021-11-01 06:18:02 PDT 
Committed r285102 (243744@main): <https://commits.webkit.org/243744@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442661 [details].