Bug 232514 - [WTF] Minor clean-up for format-related functions
Summary: [WTF] Minor clean-up for format-related functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-29 15:50 PDT by David Kilzer (:ddkilzer)
Modified: 2021-11-02 15:20 PDT (History)
8 users (show)

See Also:


Attachments
Patch v1 (3.28 KB, patch)
2021-10-29 15:52 PDT, David Kilzer (:ddkilzer)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (2.54 KB, patch)
2021-11-02 13:36 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-10-29 15:50:39 PDT
Minor clean-up for format-related functions.
Comment 1 David Kilzer (:ddkilzer) 2021-10-29 15:52:50 PDT
Created attachment 442876 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2021-10-29 16:04:35 PDT
Comment on attachment 442876 [details]
Patch v1

Need to compile macOS as well!
Comment 3 David Kilzer (:ddkilzer) 2021-11-02 13:36:33 PDT
Created attachment 443129 [details]
Patch v2
Comment 4 David Kilzer (:ddkilzer) 2021-11-02 13:37:41 PDT
(In reply to David Kilzer (:ddkilzer) from comment #3)
> Created attachment 443129 [details]
> Patch v2

Dropped the changes to Assertions.h since macOS has some `LOG()` calls that don't have any arguments past the `format` string.
Comment 5 Yusuke Suzuki 2021-11-02 14:46:38 PDT
Comment on attachment 443129 [details]
Patch v2

r=me
Comment 6 David Kilzer (:ddkilzer) 2021-11-02 15:13:54 PDT
Comment on attachment 443129 [details]
Patch v2

Marking as cq+ since this built successfully on a sufficient number of platforms.
Comment 7 EWS 2021-11-02 15:19:29 PDT
Committed r285188 (243817@main): <https://commits.webkit.org/243817@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443129 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-02 15:20:21 PDT
<rdar://problem/84949628>