Bug 234932 - check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_REACHED() statements
Summary: check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 234964 234965 234967 234971 235037 234944 234975 234986 234989 234991
  Show dependency tree / graph
 
Reported: 2022-01-06 12:22 PST by David Kilzer (:ddkilzer)
Modified: 2022-01-10 10:58 PST (History)
7 users (show)

See Also:

Attachments
Patch v1 (16.01 KB, patch)
2022-01-06 12:57 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-01-06 12:22:50 PST 
check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_REACHED() statements.

Would have found issues like this:

Bug 234852: CrashTracer: com.apple.WebKit.Networking at com.apple.WebKit: WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess
<https://bugs.webkit.org/show_bug.cgi?id=234852>
Comment 1 Radar WebKit Bug Importer 2022-01-06 12:23:38 PST 
<rdar://problem/87213520>
Comment 2 David Kilzer (:ddkilzer) 2022-01-06 12:57:16 PST 
Created attachment 448529 [details]
Patch v1
Comment 3 Brent Fulgham 2022-01-07 10:56:47 PST 
Comment on attachment 448529 [details]
Patch v1

Looks good. Thank you for doing this.
Comment 4 EWS 2022-01-07 14:59:08 PST 
Committed r287789 (245849@main): <https://commits.webkit.org/245849@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448529 [details].