Bug 235268 - Only use `diff --binary` switch on Windows
Summary: Only use `diff --binary` switch on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 27323
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-15 11:38 PST by David Kilzer (:ddkilzer)
Modified: 2022-01-15 15:11 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (1.36 KB, patch)
2022-01-15 11:40 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-01-15 11:38:02 PST 
Only use `diff --binary` switch on Windows.

It was originally added for Windows ports that were not using Cygwin:

Bug 27323: Further improve non-Cygwin SVN support.
<https://bugs.webkit.org/show_bug.cgi?id=27323>
<https://commits.webkit.org/r46095>
Comment 1 David Kilzer (:ddkilzer) 2022-01-15 11:38:15 PST 
<rdar://problem/87490487>
Comment 2 David Kilzer (:ddkilzer) 2022-01-15 11:40:15 PST 
Created attachment 449260 [details]
Patch v1
Comment 3 Alexey Proskuryakov 2022-01-15 11:46:16 PST 
Comment on attachment 449260 [details]
Patch v1

Do "-u -a" mean the same thing as expected in the scenario that you are addressing?
Comment 4 David Kilzer (:ddkilzer) 2022-01-15 14:46:21 PST 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 449260 [details]
> Patch v1
> 
> Do "-u -a" mean the same thing as expected in the scenario that you are
> addressing?

Yes.
Comment 5 EWS 2022-01-15 15:11:31 PST 
Committed r288068 (246088@main): <https://commits.webkit.org/246088@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449260 [details].