Bug 236202 - [WASM] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WasmLLIntGenerator.cpp
Summary: [WASM] Fix clang tidy bugprone-move-forwarding-reference static analyzer warn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-06 10:08 PST by David Kilzer (:ddkilzer)
Modified: 2022-02-10 12:37 PST (History)
8 users (show)

See Also:


Attachments
Patch v1 (1.55 KB, patch)
2022-02-06 10:09 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-02-06 10:08:23 PST
Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WasmLLIntGenerator.cpp.

This occurs in the JSC::Wasm::LLIntGenerator::ControlType() constructor.

Found by clang static analyzer.
Comment 1 Radar WebKit Bug Importer 2022-02-06 10:09:01 PST
<rdar://problem/88545940>
Comment 2 David Kilzer (:ddkilzer) 2022-02-06 10:09:50 PST
Created attachment 451042 [details]
Patch v1
Comment 3 Yusuke Suzuki 2022-02-06 11:15:27 PST
Comment on attachment 451042 [details]
Patch v1

r=me
Comment 4 David Kilzer (:ddkilzer) 2022-02-06 11:19:19 PST
Comment on attachment 451042 [details]
Patch v1

Marking cq+ since enough builds/tests passed to verify this small change.
Comment 5 EWS 2022-02-06 12:05:28 PST
Committed r289175 (246870@main): <https://commits.webkit.org/246870@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451042 [details].