Bug 236663 - [WebKitLegacy] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings
Summary: [WebKitLegacy] Fix clang tidy bugprone-move-forwarding-reference static analy...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-15 13:02 PST by David Kilzer (:ddkilzer)
Modified: 2022-02-16 10:22 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (1.45 KB, patch)
2022-02-15 13:52 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-02-15 13:02:39 PST 
Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WebKitLegacy.

Found by clang static analyzer.

Only one issue remaining after WTF fixes in Source/WebKitLegacy/mac/Misc/WebDownload.mm.
Comment 1 Radar WebKit Bug Importer 2022-02-15 13:02:54 PST 
<rdar://problem/88982792>
Comment 2 David Kilzer (:ddkilzer) 2022-02-15 13:52:24 PST 
Created attachment 452088 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2022-02-16 07:36:11 PST 
Comment on attachment 452088 [details]
Patch v1

Adding cq+ since mac-wk1 tests passed.
Comment 4 EWS 2022-02-16 10:22:25 PST 
Committed r289909 (247339@main): <https://commits.webkit.org/247339@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452088 [details].