RESOLVED FIXED 241437
WebGPU::ShaderModule::convertCheckResult() should use std::forward 
https://bugs.webkit.org/show_bug.cgi?id=241437
Summary WebGPU::ShaderModule::convertCheckResult() should use std::forward
David Kilzer (:ddkilzer)
Reported Wednesday, June 8, 2022 9:46:27 PM UTC
WebGPU::ShaderModule::convertCheckResult() should use std::forward. Found by clang static analyzer: Source/WebGPU/WebGPU/ShaderModule.mm:125:16: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference] return WTFMove(check); ^
Attachments
Patch v1 (1.16 KB, patch)
2022-06-08 14:05 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 Wednesday, June 8, 2022 9:46:44 PM UTC
<rdar://problem/94662366>
David Kilzer (:ddkilzer)
Comment 2 Wednesday, June 8, 2022 10:05:15 PM UTC
Created attachment 460102 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 Thursday, June 9, 2022 5:06:54 AM UTC
Comment on attachment 460102 [details] Patch v1 Marking as cq+ since enough builds/tests have passed.
EWS
Comment 4 Thursday, June 9, 2022 5:56:06 AM UTC
Committed r295409 (251415@main): <https://commits.webkit.org/251415@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460102 [details].
Note You need to log in before you can comment on or make changes to this bug.