Bug 245301 - Complete id-ref reflection implementation for ARIAAttributes
Summary: Complete id-ref reflection implementation for ARIAAttributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 244972 245299 245467
Blocks: 196843
  Show dependency tree / graph
 
Reported: 2022-09-16 14:05 PDT by Ryosuke Niwa
Modified: 2022-10-10 11:34 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-09-16 14:05:06 PDT 
The implementation of id-ref reflection is incomplete. 
We need to finish this work before we can ship this feature.
Comment 1 Radar WebKit Bug Importer 2022-09-16 14:05:21 PDT 
<rdar://problem/100042185>
Comment 2 Manuel Rego Casasnovas 2022-09-19 00:56:33 PDT 
Thanks for filling the issues.

(In reply to Ryosuke Niwa from comment #0)
> The implementation of id-ref reflection is incomplete. 
> We need to finish this work before we can ship this feature.

Should we switch off AriaReflectionForElementReferencesEnabled flag until these issues are fixed?
Comment 3 Ryosuke Niwa 2022-09-20 01:28:48 PDT 
(In reply to Manuel Rego Casasnovas from comment #2)
> Thanks for filling the issues.
> 
> (In reply to Ryosuke Niwa from comment #0)
> > The implementation of id-ref reflection is incomplete. 
> > We need to finish this work before we can ship this feature.
> 
> Should we switch off AriaReflectionForElementReferencesEnabled flag until
> these issues are fixed?

I'd recommend that given the primary motivation of element reflection was making ARIA work with shadow DOM.
Comment 4 Ryosuke Niwa 2022-09-23 20:58:52 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4660
Comment 5 EWS 2022-09-23 21:01:44 PDT 
Test gardening commit 254818@main (9dc671ed1a7b): <https://commits.webkit.org/254818@main>

Reviewed commits have been landed. Closing PR #4660 and removing active labels.
Comment 6 EWS 2022-10-10 11:34:04 PDT 
Committed 255358@main (3de868265f67): <https://commits.webkit.org/255358@main>

Reviewed commits have been landed. Closing PR #5179 and removing active labels.