Bug 35393 - [Qt] GraphicsLayer: performance optimizations
Summary: [Qt] GraphicsLayer: performance optimizations
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Noam Rosenthal
URL:
Keywords: Performance, Qt
Depends on:
Blocks: 35784
  Show dependency tree / graph
 
Reported: 2010-02-25 09:42 PST by Noam Rosenthal
Modified: 2010-04-20 12:08 PDT (History)
4 users (show)

See Also:

Attachments
Test case - lots of composited layers, takes longer to render with AC than without (24.80 KB, text/html)
2010-03-19 06:36 PDT, Noam Rosenthal 		no flags Details
Use ItemCoordinateCache and no ItemUsesExtendedStyleOption (7.30 KB, patch)
2010-04-15 18:07 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-02-25 09:42:05 PST 
currently all HTML items try to cache themselves. that could lead to a clog if, for example, the root layer is large has some HTML.
Comment 1 Tor Arne Vestbø 2010-03-05 09:39:49 PST 
Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit

    http://trac.webkit.org/wiki/QtWebKitBugs#Component
Comment 2 Noam Rosenthal 2010-03-19 06:36:11 PDT 
Created attachment 51151 [details]
Test case - lots of composited layers, takes longer to render with AC than without
Comment 3 Noam Rosenthal 2010-04-15 18:07:10 PDT 
Created attachment 53497 [details]
Use ItemCoordinateCache and no ItemUsesExtendedStyleOption

This patch aligns our implementation with the CA implementation - everything is cached in item coordinates and caches its full contents.
Comment 4 WebKit Commit Bot 2010-04-16 00:25:30 PDT 
Comment on attachment 53497 [details]
Use ItemCoordinateCache and no ItemUsesExtendedStyleOption

Clearing flags on attachment: 53497

Committed r57718: <http://trac.webkit.org/changeset/57718>
Comment 5 WebKit Commit Bot 2010-04-16 00:25:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Hausmann 2010-04-20 12:08:23 PDT 
Revision r57718 cherry-picked into qtwebkit-2.0 with commit 3e5efac4a026ca77206f338434d2e2ee66d24965