Bug 36569 - SQLStatementErrorCallback's return value needs to be converted to a boolean
Summary: SQLStatementErrorCallback's return value needs to be converted to a boolean
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-24 18:12 PDT by Dumitru Daniliuc
Modified: 2011-04-19 05:15 PDT (History)
4 users (show)

See Also:

Attachments
patch (11.10 KB, patch)
2010-03-24 18:59 PDT, Dumitru Daniliuc 		dumi: commit-queue-
Details | Formatted Diff | Diff
patch (11.60 KB, patch)
2010-03-24 20:36 PDT, Dumitru Daniliuc 		dumi: commit-queue-
Details | Formatted Diff | Diff
patch (12.30 KB, patch)
2010-03-25 12:55 PDT, Dumitru Daniliuc 		dglazkov: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-03-24 18:12:57 PDT 
Basically, we need to revert http://trac.webkit.org/changeset/54981. I have just talked to Hixie again, and he agreed that we should convert SQLStatementErrorCallback's return value to a boolean, instead of treating false as false, and everything else as true. This means that values such as undefined (no return value), or 0, or "false" will all be treated as false, as a Javascript developer might expect.
Comment 1 Dumitru Daniliuc 2010-03-24 18:59:26 PDT 
Created attachment 51578 [details]
patch
Comment 2 WebKit Review Bot 2010-03-24 19:06:21 PDT 
Attachment 51578 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1183025
Comment 3 Dumitru Daniliuc 2010-03-24 20:36:24 PDT 
Created attachment 51587 [details]
patch

Should fix the Chromium build problems.
Comment 4 Dumitru Daniliuc 2010-03-25 12:55:18 PDT 
Created attachment 51672 [details]
patch

Same patch, without style errors this time, hopefully.
Comment 5 Dimitri Glazkov (Google) 2010-03-25 13:59:20 PDT 
Comment on attachment 51672 [details]
patch

ok.
Comment 6 Dumitru Daniliuc 2010-03-25 15:30:15 PDT 
Landed as r56572.
Comment 7 Simon Hausmann 2010-06-13 14:06:43 PDT 
Revision r56572 cherry-picked into qtwebkit-2.0 with commit 9917209df84aa5a739d112570394d9f57e99689b