CLOSED FIXED 36590
[Qt] Build JavaScriptCore as a static library
https://bugs.webkit.org/show_bug.cgi?id=36590
Summary [Qt] Build JavaScriptCore as a static library
Jocelyn Turcotte
Reported Thursday, March 25, 2010 11:49:15 AM UTC
Currently, JavaScriptCore is build by including JavaScriptCore.pri in WebCore.pro, jsc.pro and QtScript.pro. This .pri file just add JavaScriptCore's cpp files to the SOURCES variable. Building JavaScriptCore statically before would prevent recompiling JavaScriptCore's cpp files for each project and would allow its objects files to be compiled with different optimization flags.
Attachments
Patch (19.38 KB, patch)
2010-03-25 03:52 PDT, Jocelyn Turcotte
no flags
Patch v2 (19.00 KB, patch)
2010-03-25 04:16 PDT, Jocelyn Turcotte
hausmann: review+
Jocelyn Turcotte
Comment 1 Thursday, March 25, 2010 11:52:10 AM UTC
Jocelyn Turcotte
Comment 2 Thursday, March 25, 2010 12:16:52 PM UTC
Created attachment 51627 [details] Patch v2 Removes unrelated hunk.
Simon Hausmann
Comment 3 Friday, March 26, 2010 4:51:31 PM UTC
Simon Hausmann
Comment 4 Friday, March 26, 2010 4:53:43 PM UTC
Revision r56623 cherry-picked into qtwebkit-2.0 with commit b9a9ed485914673c4801be819f8906e933666435
Ismail Donmez
Comment 5 Saturday, March 27, 2010 11:15:46 AM UTC
This breaks the WinCE build (reverting the commit fixes the build ), I get: pcre_compile.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_exec.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_tables.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_ucp_searchfuncs.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_xclass.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory Looks like JavaScriptCore/os-win32 is not being added to includepath.
Simon Hausmann
Comment 6 Monday, March 29, 2010 11:31:51 AM UTC
(In reply to comment #5) > This breaks the WinCE build (reverting the commit fixes the build ), I get: Filed #36751
Simon Hausmann
Comment 7 Monday, March 29, 2010 11:32:10 AM UTC
(In reply to comment #6) > (In reply to comment #5) > > This breaks the WinCE build (reverting the commit fixes the build ), I get: > > Filed #36751 Err https://bugs.webkit.org/show_bug.cgi?id=36751
Note You need to log in before you can comment on or make changes to this bug.