to make webkit compile on a linux box using gcce and cross compiling to arm for symbian I found that the attached change was required.
Created attachment 51886 [details] fix
Attachment 51886 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 51886 [details] fix In Qt 4.6 the variable is called defFilePath. This patch would break support building with def files against Qt 4.6. How about simply setting both variables? :)
(In reply to comment #2) > Attachment 51886 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > Total errors found: 0 in 0 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I think the reason for this is because the patch doesn't apply with -p1 but only with -p0.
Created attachment 51891 [details] updated patch
Comment on attachment 51891 [details] updated patch Looks good to me. I'll land it manually to add a link to bugzilla to the ChangeLog.
Committed r56714: <http://trac.webkit.org/changeset/56714>
Revision r56714 cherry-picked into qtwebkit-2.0 with commit 5df858f8f4da97d738f8e957eabc8398a1e5bfb4
Created attachment 52063 [details] Proposed patch to fix a build break on Symbian QTWebkit build. This patch fixes comment character from ";" to "#" in the "symbian" section of .pro file. Was discovered while running qmake on Webcore.pro with QT 4.6.2 for Symbian. Was getting an error at line 2940: Parse Error (;; defFilePath is for Qt4.6 compatibility') Unterminated conditional block at end of file.
Attachment 52063 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 File not a recognized type to check. Skipping: "WebCore/WebCore.pro" WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 52072 [details] Modified previous patch to convert Tabs to spaces
Comment on attachment 52072 [details] Modified previous patch to convert Tabs to spaces r+, thanks for the patch. Next time please make sure the text is properly aligned in the ChangeLog. This time I fix the ChangeLog when I commit.
Landed as http://trac.webkit.org/changeset/56822.
cherry-pick-for-backport: <r56822>
Revision r56822 cherry-picked into qtwebkit-2.0 with commit 4b42600cfd2bc353ecbc64efc03b7aaf6d7e0bbf