Bug 37100 - [Symbian] Consolidate Symbian WINSCW environment configuration
Summary: [Symbian] Consolidate Symbian WINSCW environment configuration
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 35784
  Show dependency tree / graph
 
Reported: 2010-04-05 11:26 PDT by Laszlo Gombos
Modified: 2010-04-06 02:59 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (2.60 KB, patch)
2010-04-05 11:32 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
2nd try, remove extra whitespace (2.45 KB, patch)
2010-04-05 11:34 PDT, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-04-05 11:26:22 PDT 
WINSCW is a cross-compilation environment running on Windows. For this environment WIN32, OS(WIN) and PLATFORM(WIN) should not be defined.

Currently some of this logic is in WebCore/config.h and some in JavaScriptCore/wtf/Platform.h. It make sense to consolidate this logic into Platform.h as this is related to global environment setup for WINSCW. 

For example after r56623 WIN32 is _not_ defined when compiling WebCore with WINSCW but it is defined when compiling JavaScriptCore. This can lead to hard-to-find build issues.
Comment 1 Laszlo Gombos 2010-04-05 11:32:24 PDT 
Created attachment 52547 [details]
proposed patch
Comment 2 Laszlo Gombos 2010-04-05 11:34:27 PDT 
Created attachment 52548 [details]
2nd try, remove extra whitespace
Comment 3 WebKit Commit Bot 2010-04-05 17:55:25 PDT 
Comment on attachment 52548 [details]
2nd try, remove extra whitespace

Clearing flags on attachment: 52548

Committed r57108: <http://trac.webkit.org/changeset/57108>
Comment 4 WebKit Commit Bot 2010-04-05 17:55:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2010-04-06 02:55:49 PDT 
<cherry-pick-for-backport: r57076>
Comment 6 Simon Hausmann 2010-04-06 02:59:47 PDT 
Revision r57076 cherry-picked into qtwebkit-2.0 with commit ac69c2f69372089990b04b3425da1d2eb2697ae0
Revision r57108 cherry-picked into qtwebkit-2.0 with commit 5bfb5ac38f9981f950c7116001844d3f7b681d67