Bug 38062 - [Qt] HTTP pipelining efficiency increase
Summary: [Qt] HTTP pipelining efficiency increase
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords: Performance, Qt
Depends on:
Blocks: 35784
  Show dependency treegraph
 
Reported: 2010-04-23 15:44 PDT by Siddharth Mathur
Modified: 2010-04-26 08:32 PDT (History)
3 users (show)

See Also:


Attachments
Screenshot of wire capture (1.65 MB, image/jpeg)
2010-04-23 15:44 PDT, Siddharth Mathur
no flags Details
Patch (1.43 KB, patch)
2010-04-26 06:01 PDT, Markus Goetz
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Siddharth Mathur 2010-04-23 15:44:26 PDT
Created attachment 54197 [details]
Screenshot of wire capture 

[result of work by Markus Goetz as part of QTBUG-9894]

To get HTTP pipelining to work at all on Qt-Symbian, and work better in other Qt ports, the values in initializeMaximumHTTPConnectionCountPerHost() in the following file need to fixed up. 

\WebCore\platform\network\qt\ResourceRequestQt.cpp

I verified on N97 that changing the Symbian max value to 3 * (1+3) makes at least a few requests start getting pipelined, where there were previously _zero_ in vanilla Qt 4.6.2.
Comment 1 Simon Hausmann 2010-04-26 02:23:48 PDT
Let's get the fix into the 2.0 branch
Comment 2 Markus Goetz 2010-04-26 06:01:38 PDT
Created attachment 54285 [details]
Patch
Comment 3 Siddharth Mathur 2010-04-26 06:42:06 PDT
Looks good to me, and thanks for the investigation Markus!
Comment 4 Simon Hausmann 2010-04-26 07:37:14 PDT
Committed r58254: <http://trac.webkit.org/changeset/58254>
Comment 5 Simon Hausmann 2010-04-26 07:41:11 PDT
Cherry-picked into qtwebkit-4.6 with commit
4b36f14a0ee2b25bf534f5691bea09ad0616d67d
Comment 6 Simon Hausmann 2010-04-26 08:28:23 PDT
Revision r58254 cherry-picked into qtwebkit-2.0 with commit 417bc302e719c47f787df4e9e463c93f83006386