Bug 38125 - View modes names in CSSValueKeywords.in
Summary: View modes names in CSSValueKeywords.in
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35784
  Show dependency tree / graph
 
Reported: 2010-04-26 07:15 PDT by Luiz Agostini
Modified: 2010-05-05 08:14 PDT (History)
3 users (show)

See Also:

Attachments
patch 1 (1.47 KB, patch)
2010-04-26 07:21 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
patch 2 (1.47 KB, patch)
2010-04-26 07:38 PDT, Luiz Agostini 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-04-26 07:15:07 PDT 
View mode names has changed in previous patch but CSSValueKeywords.in file was not updated. Layout tests should fail but they do not because of bug 38116.
Comment 1 Luiz Agostini 2010-04-26 07:21:24 PDT 
Created attachment 54294 [details]
patch 1
Comment 2 Laszlo Gombos 2010-04-26 07:22:57 PDT 
Looks good, but should we sort these strings when possible ?
Comment 3 Luiz Agostini 2010-04-26 07:32:34 PDT 
(In reply to comment #2)
> Looks good, but should we sort these strings when possible ?

no problem. :)
Comment 4 Luiz Agostini 2010-04-26 07:38:30 PDT 
Created attachment 54299 [details]
patch 2
Comment 5 WebKit Commit Bot 2010-04-26 09:21:52 PDT 
Comment on attachment 54299 [details]
patch 2

Clearing flags on attachment: 54299

Committed r58258: <http://trac.webkit.org/changeset/58258>
Comment 6 WebKit Commit Bot 2010-04-26 09:21:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Hausmann 2010-05-05 08:14:03 PDT 
Revision r58258 cherry-picked into qtwebkit-2.0 with commit ddf1a58c83038dfe71ff66417d4a4a8d0c3a2bb5